-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 adding SubjectAccessReview.authorization.k8s.io/v1 webhook support #1535
🌱 adding SubjectAccessReview.authorization.k8s.io/v1 webhook support #1535
Conversation
Welcome @rfranzke! |
Hi @rfranzke. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
/test pull-controller-runtime-test-master |
65b39cc
to
5802051
Compare
/test pull-controller-runtime-test-master |
1 similar comment
/test pull-controller-runtime-test-master |
/lgtm |
5802051
to
32afe3f
Compare
/remove-lifecycle stale @vincepri are you able to take a look at this? |
/assign @alvaroaleman |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
@rfranzke @alvaroaleman what should we do with this? |
Well, I don't know why this PR was not yet approved, especially in the light that it is very similar to #1440. /remove-lifecycle rotten |
@rfranzke: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rfranzke @alvaroaleman @christopherhein @vincepri @estroz Although it is closed by stale long time ago, I'm now very interested in this PR. I would like to contribute to getting this PR merged. I would be happy if you advise me for how to proceed. /reopen |
@everpeace: Failed to re-open PR: state cannot be changed. The master branch has been deleted. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Similar to #1440, this PR adds a new
pkg/webhook/authorization/
package for setting up theServeHTTP
func for the webook server to be able to handleSubjectAccessReview.authorization.k8s.io/(v1,v1beta1)
requests.It allows third-party programs to focus on their business logic while controller-runtime providers the necessary boilerplate for handling such HTTP requests.
For more background, see also #1436 (comment).